Skip to content

Conversation

@madaleines
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
Why is it useful to put classes inside modules? so other classes can access each others' info under the one module
What is accomplished with raise ArgumentError?
Why do you think we made the .all & .find methods class methods? Why not instance methods? because there is so much data to sort through?
Why does it make sense to use inheritance for the online order? To not have make duplicate code because it inherits a lot of the same 'traits' as Order
Did the presence of automated tests change the way you thought about the problem? How? yes, I wanted to do the code before the tests

@tildeee
Copy link

tildeee commented Feb 26, 2018

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions x. For the question "Why do you think we made the .all & .find methods class methods? Why not instance methods?", you answered with uncertainty. The answer is: .all and .find functionally do not operate on an instance of Order or OnlineOrder; they operate on a level that isn't concerned with one specific instance, but on the level of all Orders and OnlineOrders.
Used Git Regularly x
Wave 1
All provided tests pass x
Using the appropriate attr_ for instance variables x
Wave 2
All stubbed tests are implemented fully and pass
Appropriately parses the product data from CSV file in Order.all x
Used CSV library only in Order.all (not in Order.find) x
Used Order.all to get order list in Order.find
Wave 3
All stubbed tests are implemented fully and pass
Used inheritance in the initialize for online order
Used inheritance for the total method in online order
Use CSV library only in OnlineOrder.all
Used all to get order list in find
Appropriately searches for Customer orders in find_by_customer
Additional Notes

The tests and implementation that you have are passing and good!

However, you didn't get to finish Wave 2 or work on Wave 3.

The learning goals of wave 2 and wave 3 are the following, and I want you to figure out how to make sure you're getting practice on these topics:

  • Independently writing your own tests
  • Calling methods from other methods (calling all in the implementation of find)
  • Inheritance and using super

By the way, the comments you have in the order.rb file which are your notes about the requirements are good and accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants