Ampers: Kaitlin Forsman #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Order.all method and tests
…and got it to pass :D
…to match online order and pass written test
…hange the method from the Online class
…ote and rewrote code to pass test
…ll the nils with ArgumentErrors
Grocery StoreWhat We're Looking For
|
CheezItMan
reviewed
Feb 22, 2018
| end | ||
| # returns array of all orders in the CSV | ||
| def self.all | ||
| @@all_orders = [] |
There was a problem hiding this comment.
If you're resetting @@all_orders each time self.all is called, why make it a class variable. It's just as good as a local variable.
| return order | ||
| end | ||
| end | ||
| raise ArgumentError |
There was a problem hiding this comment.
You should probably not raise an ArgumentError here. It would make sense to return nil when you can't find such an order.
| super(id, products) | ||
| @customer_id = customer_id | ||
| @customer = Customer.find(@customer_id) | ||
| if status.class == Symbol |
There was a problem hiding this comment.
This if/else is unnecessary as symbols also have a to_sym method
| # inherited method from order class that adds 10 for shipping to the total | ||
| # if order is greater than 0 | ||
| def total | ||
| if super == 0 |
| # method to return an array of all orders from a single customers | ||
| # from the input of their customer id | ||
| def self.find_by_customer(customer_id) | ||
| Customer.find(customer_id) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grocery Store
Congratulations! You're submitting your assignment.
Comprehension Questions
raise ArgumentError?.all&.findmethods class methods? Why not instance methods?