Luxi Lindsey - Grocery Store - Octos

[Lindseyls]

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Response
Why is it useful to put classes inside modules?	It is useful because then you can easily call and access the classes within the module by using namespacing ModuleName::ClassName.
What is accomplished with raise ArgumentError?	I am able to not just give the user an error when the status is not pending or paid, but also can give them the information on why there is an error or most importantly why the new product was not able to be added to the order.
Why do you think we made the .all & .find methods class methods? Why not instance methods?	We made the '.all' and '.find' methods class methods because we are calling on the orders from the class itself. The orders are objects within the class. Therefore, in order to go through each line order in the class in order to find all the orders or specific orders based on the id, we need to call upon the whole class.
Why does it make sense to use inheritance for the online order?	It makes sense because Online Order is a class related to the Order class. By using inheritance we were able to inherit methods and use super to invoke behavior from the Order class so that we can write less code.
Did the presence of automated tests change the way you thought about the problem? How?	It definitely gave me clear instructions on what code I needed to write in order to make sure they are meant to do what the questions ask for. However, I am still unclear on how to write the most affective tests and look forward to learning more about that and perfecting my tests.

[tildeee]

Grocery Store

What We're Looking For

Feature	Feedback
Baseline
Answered comprehension questions	x
Used Git Regularly	x
Wave 1
All provided tests pass	x
Using the appropriate attr_ for instance variables	x
Wave 2
All stubbed tests are implemented fully and pass	x
Appropriately parses the product data from CSV file in Order.all	x
Used CSV library only in Order.all (not in Order.find)	x
Used Order.all to get order list in Order.find	x
Wave 3
All stubbed tests are implemented fully and pass	x
Used inheritance in the initialize for online order	x
Used inheritance for the total method in online order	x
Use CSV library only in OnlineOrder.all	x
Used all to get order list in find	x
Appropriately searches for Customer orders in find_by_customer	x, n/a
Additional Notes

Good work overall.

Stylistically the code looks good and functions well.

One small thing about constant variables:
You use the constant variable FILE_NAME to describe the path to the CSV files. However, you should be intentional with the scope that the constant variable gets: in this case, we want FILE_NAME to be within the Order class, and FILE_NAME to be within the OnlineOrder class.

The tests are a little "rough"!

To write effective tests, you should think about the following:

• What action (method) am I trying to test/verify/validate?
• What is the expected behavior? What are the expected states?

For instance, you have some tests in the order spec about Order.all, such as the following:

it "Returns accurate information about the last order" do
      order = Grocery::Order.all

      order[99].must_be_kind_of Grocery::Order
    end

You successfully test that the order at index 99 should be an instance of the Order class. But what else can we verify?

It would be great if you could verify that the information about the last order that we know from the CSV (it has an ID of 100, and the products represented by the string "Allspice:64.74;Bran:14.72;UnbleachedFlour:80.59"). You can do things like that with order[99].id.must_equal 100.

I think you're on your way to writing better tests in the future :)

Good job overall!