&&: Kate Pond #22

Oh-KPond · 2018-02-20T07:54:13Z

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Response
Why is it useful to put classes inside modules?	By putting classes inside modules, the program can run different methods without causing collision problems. E.g. Grocery::Customer.id and Grocery::OnlineOrder.id both call an instance variable @id but with namespacing, no naming collisions happen
What is accomplished with `raise ArgumentError`?	`raise ArgumentError` creates a better user experience. So when an invalid entry is given, the user is alerted instead of given nothing or an error they don't understand.
Why do you think we made the `.all` & `.find` methods class methods? Why not instance methods?	By making the `.all` & `.find` methods class methods we are able to use them for all instances instead on just one instance.
Why does it make sense to use inheritance for the online order?	Since online order is a type of order, it's nice to be able to use some of the methods from the order class instead of duplicating code.
Did the presence of automated tests change the way you thought about the problem? How?	I love testing! I can't wait to get better at creating them. While I was creating tests I was able to think about all the ways that I might be able to get to the solution. Writing tests really helped me process what the program was looking for. Like I said though, I'm really looking forward to getting better at test writing.

…rder'

Oh-KPond · 2018-02-20T08:01:39Z

Hahaha... okay so maybe I have an excessive amount of commits. I committed whenever I thought that I had finished a thought. I will attempt to bundle better. In the future, I may commit tests and code together instead of the test, then the code, then all the refactoring. :shrug #design

p.s. I know that some of my tests are still failing... darn!!

CheezItMan · 2018-02-23T01:51:33Z

Grocery Store

What We're Looking For

Feature	Feedback
Baseline
Answered comprehension questions	Check,
Used Git Regularly	Lots of commits, that's good. You also mostly have good commit messages, focus on the functionality added or changes made, not on waves.
Wave 1
All provided tests pass	Check
Using the appropriate `attr_` for instance variables	Your `products` doesn't need to be an accessor.
Wave 2
All stubbed tests are implemented fully and pass	Check
Appropriately parses the product data from CSV file in `Order.all`	Check
Used `CSV` library only in `Order.all` (not in `Order.find`)	Check
Used `Order.all` to get order list in `Order.find`	Check
Wave 3
All stubbed tests are implemented fully and pass	Not quite, see my in-line notes.
Used inheritance in the initialize for online order	Check my note on your `attr_reader`
Used inheritance for the total method in online order	Check, well done
Use `CSV` library only in `OnlineOrder.all`	Check
Used `all` to get order list in `find`	Check, good job not overriding the existing method from `Order`.
Appropriately searches for Customer orders in `find_by_customer`	NO There is a bug here. It always raises an error.
Additional Notes	Overall pretty good. You got most of the primary requirements and a few optionals. Nice work!

CheezItMan · 2018-02-23T01:32:12Z

lib/customer.rb

+      all_customers.each do |customer|
+        if id == customer.id
+          return customer
+        elsif id == "first"


Not really in the requirements, but interesting.

hahaha thanks!

CheezItMan · 2018-02-23T01:39:05Z

lib/order.rb

  class Order
-    attr_reader :id, :products
+    attr_reader :id
+    attr_accessor :products


This does not need to be an attr_accessor

CheezItMan · 2018-02-23T01:40:28Z

specs/order_spec.rb

+      # act
+      Grocery::Order.all
+      # assert
+      Grocery::Order.all.must_be_kind_of Array


You should also check that every element is an Order

CheezItMan · 2018-02-23T01:40:52Z

specs/order_spec.rb

+      # act
+      Grocery::Order.all[-1].id
+      # assert
+      Grocery::Order.all[-1].id.must_equal CSV.read('support/orders.csv', 'r')[-1][0]


CheezItMan · 2018-02-23T01:41:54Z

specs/order_spec.rb

+      #arrange
+      # N/A
+      # act
+      Grocery::Order.find("first")


It would be better to find the first Order of the file by the ID field of that order.

Something like: Grocery::Order.find(1)

CheezItMan · 2018-02-23T01:43:31Z

lib/online_order.rb

+
+module Grocery
+  class OnlineOrder < Order
+    attr_reader :id, :customer, :products, :status


Since this class inherits from Order, you don't need to define an attr_reader for id and products because they inherit them from Order.

CheezItMan · 2018-02-23T01:45:29Z

lib/online_order.rb

+
+    #self.find should come from Grocery::Order
+
+    def self.find_by_customer(customer_id)


This method always raises the ArgumentError, you should return order_array (empty if no order has that customer or if the customer has orders it should return an array of those orders.

CheezItMan · 2018-02-23T01:49:47Z

specs/online_order_spec.rb

+      # act
+      Grocery::OnlineOrder.all
+      # assert
+      Grocery::OnlineOrder.all.must_be_kind_of Array


Again make sure all the elements are OnlineOrder objects

Oh-KPond added 30 commits February 14, 2018 14:14

adds reporters to minitest files

621f270

completes wave 1

894091c

creates unit test for order.remove_product

26f2bb3

fixes unit test for order.remove_product if product is not removed

aaa4729

adds another test to order.remove_item to check item count has decreased

db83e92

cleans up indention

8d72fc3

fixes test for decreasing product count

b3bc8c8

fixes tests for remove_product

c9f982f

creates code for removing a product

997dd36

makes notes for using minitest in tests for order.remove_product

e46becd

uncomments Wave2

c80bbf0

removes duplicate require statements

b57819e

removes unused method code

e6fcfeb

creates a return array test for Order.all

0495bc8

removes arrange from Order.all test

ca9e959

creates Class method self.all

bed5c7a

creates unit test for 'Returns accurate information about the first o…

8e54c1c

…rder'

fixes test for 'Returns accurate information about the first order'

3d2c197

creates method self.first_order

4314374

creates method self.first_order

0510e9f

creates test for Grocery::Order.last_order

b73858e

creates Grocery::Order.last_order

619abe1

refactors Grocery::Order.all so that products is an array of hashes

9b408a3

refactors test and code for Grocery::Order.first_order

92f7091

refactors test and code for Grocery::Order.last_order

03d8e06

removes unused class instance variable

4c585e2

removes unused methods and updates tests: oops did work I shouldn't have

a176296

really fixes the tests for Grocery::Order.all

8607cda

creates tests for Grocery::Order.find(id)

928304f

refactors code for Order.find tests and code

9d48936

Oh-KPond added 20 commits February 19, 2018 10:19

changes test for Grocery::OnlineOrder#init to include data from csv

896a29f

completes code for Grocery::OnlineOrder#all

be13134

creates test for OnlineOrder#total 'adds shipping fee'

30575c7

gives customer access to order

577109b

corrects tests for Grocery::OnlineOrder#total

e874d55

creates Grocery::OnlineOrder#total

83acde6

creates tests for Grocery::OnlineOrder#add_product

175fe50

refactors tests for Grocery::OnlineOrder#add_product

4b7ef20

creates Grocery::OnlineOrder#add_product

08e6ee9

adds tests for OnlineOrder.find

04946a0

cleans up space in OnlineOrder.find

ee01e48

adds raise error to Order#find

c9dc322

adds proc raise Argument testing to Order.find and OnlineOrder.fins

7af73f9

adds ArgumentErrors to Order and OnlineOrder

c10b160

merge conflict fix for ArgumentError addition

7c9bca1

fixes error message for Order.find to be about orders

bbde469

creates tests for OnlineOrder.find_by_customer

7870da3

creates tests for OnlineOrder.find_by_customer

d690fe9

creates draft of OnlineOrder.find_by_customer

41545ff

Merge branch 'master' into master

7a9127b

CheezItMan reviewed Feb 23, 2018

View reviewed changes

Oh-KPond added 7 commits February 26, 2018 12:47

products only need to be a attr_reader

ac66499

fixes test for returning an array of all orders

4b7f5f7

takes suggestion for 'Can find the first order from the CSV'

0d6a1d8

removes attr from online_order since it inherits from Order

86d3888

updates test for order and online order to include instance testing

53c023f

adds pry

daf1c6d

updates tests for customer find orders

0b315a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

&&: Kate Pond #22

&&: Kate Pond #22

Uh oh!

Oh-KPond commented Feb 20, 2018 •

edited

Loading

Uh oh!

Oh-KPond commented Feb 20, 2018 •

edited

Loading

Uh oh!

CheezItMan commented Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

Oh-KPond Feb 26, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

CheezItMan Feb 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		#self.find should come from Grocery::Order

		def self.find_by_customer(customer_id)

&&: Kate Pond #22

Are you sure you want to change the base?

&&: Kate Pond #22

Uh oh!

Conversation

Oh-KPond commented Feb 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Grocery Store

Comprehension Questions

Uh oh!

Oh-KPond commented Feb 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CheezItMan commented Feb 23, 2018

Grocery Store

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Oh-KPond commented Feb 20, 2018 •

edited

Loading

Oh-KPond commented Feb 20, 2018 •

edited

Loading