Ampers Sara S #45

CheerOnMars · 2018-04-15T07:01:11Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a method to get the upvote count. In the private section of my model, I counted the upvotes.
Describe how you approached testing that model method. What edge cases did you come up with?	In the test, I confirmed that the test would return the number of times that the work was voted for in the fixture. I also made sure that the test would return zero if the work didn't receive any votes.
What are `session` and `flash`? What is the difference between them?	Flash sends a one time message to the view and is only up for that one time. Session keeps track of a user's date through a session and it lasts until it's actively exited out of.
Describe a controller filter you wrote.	I created a controller filter to find the user so that it didn't have to be repeated in my users controller.
What was one thing that you gained more clarity on through this assignment?	The magic of consistent HTML and how it makes CSS much easier
What is the Heroku URL of your deployed application?	https://cheery-media-ranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

CheezItMan · 2018-04-18T16:56:47Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Not bad, avoid commit messages like "."
Comprehension questions	Check,
General
Rails fundamentals (RESTful routing, use of named paths)	Mostly, you don't need a `new` action for upvotes. I left some notes in your code.
Semantic HTML	Check, well done!
Errors are reported to the user	Check, but there are some issues with creating a new work and authentication.
Business logic lives in the models	Check, really nice `top_ten` method!
Models are thoroughly tested, including relations, validations and any custom logic	Check, but you're missing tests for the custom methods.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Check, looks nice!
Look and feel is similar to the original	Nice work, you matched the demo style pretty effectively
Overall	Overall nice work, you need to work on testing more throughly and using flash notices everywhere. However you did hit the major learning goals. Slack me if you have questions.

CheezItMan · 2018-04-18T16:41:03Z

config/routes.rb

+
+  get '/login', to: 'sessions#new', as: 'login'
+  post '/login', to: 'sessions#create'
+  get '/logout', to: 'sessions#update', as: 'logout'


I would make this route a delete action instead of get.

CheezItMan · 2018-04-18T16:41:27Z

config/routes.rb

+  post '/logout', to: 'sessions#logout'
+
+  resources :works do
+    resources :upvotes, only: [:create, :new]


Do you need a new action for votes? Is there a form?

CheezItMan · 2018-04-18T16:45:30Z

app/controllers/sessions_controller.rb

+      session[:user_id] = @user.id
+      flash[:success] = "Successfully logged in as existing user #{@user.username}"
+    else
+      @user = User.create username: params[:user][:username]


You should have some check to make sure that create worked properly.

CheezItMan · 2018-04-18T16:48:06Z

app/views/works/_form.html.erb

+  <ul class="errors">
+    <% @work.errors.each do |column, message| %>
+    <li>
+      <strong><%= field.capitalize %></strong> <%= message %>


This is crashing the app when I try to create a work without filling in any of the fields in the form.

field should be column

Lastly you should do this with flash notices.

CheezItMan · 2018-04-18T16:52:48Z

test/models/upvote_test.rb

+  end
+
+  it 'must have a work' do
+    upvote = upvotes(:up_seventeen)


It's considered preferable to start with a valid model and then set one field to an invalid state and then check to see if that made the model invalid.

CheezItMan · 2018-04-18T16:54:18Z

test/models/work_test.rb

+require "test_helper"
+
+describe Work do
+  let(:work) { Work.new }


Similar to the upvote tests above make the work valid and then take a way a specific field to make it invalid and then test that.

CheezItMan · 2018-04-18T16:54:43Z

test/models/work_test.rb

+    work.get_upvotes_count.must_equal 0
+  end
+
+


Missing tests for the custom methods.

CheerOnMars added 30 commits April 9, 2018 14:30

rails new executed

b0ca25c

added work controler and model

2f747fa

added user controller and model

5d0aa53

added join table

5d3fabd

add schema

f343fcc

add form edit new and index page

e21a3a2

add show page and fix errors in show and index pages

9bb6498

corrected root page

e84caee

add delete method

cb70289

refind show page

29b769c

cleaned up code on work views

0753fc5

add fixtures of users and works

d0c882f

cleaned up code

f4e4bba

add upvotes and tests for works

5e681d0

create upvote tests and clean up code

03a53d1

clean up upvotes controller

9b6a3d4

add test data into upvotes fixture

c3d3ae1

add more method placeholders to user and work models

ee641c0

moved works table into the correct folder

d8114ec

add users index page

54c6023

cleaned up work fixture and model

3cf9275

cleaned up views

8665aab

cleaned up routes and session controller

fbe624c

cleaned up views

2be653f

add find_user action to controllers

817d00d

added flash functionality to app layout and messages to works controller

7dea85a

add list partial for the main page

303ee25

cleaned up code

f543cd4

complete partial list form for works index page

f6e28f8

correct login in routes and action

c972178

CheerOnMars added 28 commits April 16, 2018 19:38

removed extraneous code in sessions controller

5776381

removed extraneous code in sessions controller

bdd2746

corrected logout message

fd157e2

corrected logout message

0f62fea

standardize instance variables in sessions controller

94a7b37

cleaned up routes

81786ff

test login method

0a73d17

test login method

9e4c88a

test login method

2926ef7

test login method

d034f13

test login method

4d8b166

change name from destroy to logout in view

066b095

change name from destroy to logout in view

8b6161f

adjust logout path

b87ea51

try to fix logout path

7bab022

try to fix logout path

b3375f3

try to fix logout path

bff5af2

try to fix logout path

3f220f5

try to fix logout path

d86bb61

worked on logout path

010369a

update upvotes route

e460c68

cleaned up code

d79398d

clean up index code

06561a2

update upvotes controller

6aeea8f

correct upvotes route error

22a1254

flesh out user v current user a lil more

6ee0300

update upvote controller

ae0eaf5

.

ec6dc30

CheezItMan reviewed Apr 18, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ampers Sara S #45

Ampers Sara S #45

Uh oh!

CheerOnMars commented Apr 15, 2018 •

edited

Loading

Uh oh!

CheezItMan commented Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ampers Sara S #45

Are you sure you want to change the base?

Ampers Sara S #45

Uh oh!

Conversation

CheerOnMars commented Apr 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented Apr 18, 2018

Media Ranker

What We're Looking For

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CheerOnMars commented Apr 15, 2018 •

edited

Loading