Victoria Garcia : Ampers : 1 hour late #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry much subject to change.
…ch subject to change.
…to the params methods in the users and works controllers to accommodate the actual fields in the various tables.
…chanism in place.
… Works is officially functional; YAMLs for Vote and User are not yet tested, but written
…re written and passing.
…hing is working yet, however.
…ing up is now fixed.
…ifications are still needed.
…breaking up login methods in Session to allow appropriate redirection.
… I only have six hours left.
… have to be both the last commit and the last branch.
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
Apr 18, 2018
|
|
||
| resources :users, except: [:edit, :update] | ||
|
|
||
| resources :votes, except: [:new, :create, :destroy] |
There was a problem hiding this comment.
So people can edit, and update votes? What about index and show?
| <%= link_to "See all Users", users_path, class: 'button' %> | ||
| <%= link_to "Back to Media List", works_path, class: 'button' %> | ||
|
|
||
| <h1><%= Work.find_by(title: "Dogzilla").title %></h1> |
There was a problem hiding this comment.
This is causing the site to crash. Did you leave it in by accident?
|
|
||
| validate :one_vote_per_user_per_work | ||
|
|
||
| def one_vote_per_user_per_work |
There was a problem hiding this comment.
Neat custom validation. You can also do something similar with uniqueness and scope like in the rails api guide
| end | ||
|
|
||
| def self.report_works_voted_for(id_for_user) | ||
| @upvoted_works = self.where(user_id: id_for_user) |
There was a problem hiding this comment.
I don't think this method is really very useful as any Work instance has a votes method.
| validates :title, length: { in: 1..35 } | ||
|
|
||
|
|
||
| def self.works_with_vote_tallies |
There was a problem hiding this comment.
These methods seems overly complicated. Couldn't you do a method to get the works in order by the number of votes with:
works = Work.all.to_a
return works.sort_by { |work| -work.total_votes }And you can always get the vote tally for a work with: work.votes.count
| end | ||
|
|
||
|
|
||
| it "contains elements in which index position 1 is the correct tally of votes for the element at index position 0" do |
| work.valid?.must_equal false | ||
| end | ||
|
|
||
| describe "works_with_vote_tallies" do |
There was a problem hiding this comment.
You should also test this method when no votes have been issued for any work, and when there are no works period.
|
|
||
| describe "works_ordered_by_popularity" do | ||
|
|
||
| it "returns an array" do |
|
|
||
| def show | ||
| id = params[:id] | ||
| @work = Work.find(id) |
| flash[:alert] = @vote.errors | ||
| end | ||
| end | ||
| redirect_to work_path(params[:work_id]) |
There was a problem hiding this comment.
Maybe redirect_back would be better here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: THIS IS AN UPDATED PULL REQUEST. I spotted several major bugs after deployment (the worst having to do with a problem on form for Work, and a couple of other having to do with bad redirects, plus one to do with an improper tag on the Work show page, and one to do with a raise left in the vote model.) I fixed them as of 4/15.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?