&& Nicoleta B #41
Open
&& Nicoleta B #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes for votes, added dependent/destroy on models
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
Apr 18, 2018
| has_many :votes, dependent: :destroy | ||
| validates :title, presence: true | ||
| validates :category, presence: true | ||
| validates :category, inclusion: { in: %w(movie book album)} |
| if @user | ||
| session[:user_id] = @user.id | ||
| else | ||
| @user = User.create user_name: params[:user][:user_name] |
There was a problem hiding this comment.
You should check to verify that create worked! I tried to log in with a blank username and got no error message.
| value(user).must_be :valid? | ||
| end | ||
|
|
||
| it "requires a unique username" do |
There was a problem hiding this comment.
You also need to test with blank or nil usernames
| user2.errors.messages.must_include :user_name | ||
| end | ||
|
|
||
| describe "total_votes" do |
There was a problem hiding this comment.
This makes more sense in the works model
| it "must be invalid without a supported category type" do | ||
| work.category = "gdfhjgfhjd" | ||
| value(work).wont_be :valid? | ||
| end |
There was a problem hiding this comment.
You also need to test your custom methods bot in the nominal cases and in the case where there are no works or votes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?