Ampers - Mariko A. - Media Ranker #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and works, added foreign keys to votes
…ace for top media, and top ten for each category
…ks show pages. Oh and nested routes for votes create.
…er is informed of what errors occured based on validations.
…ted user show view, probably other shit too.
…ique to category. Users must be logged in to vote.
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
Apr 18, 2018
|
|
||
| root 'welcomes#index' | ||
|
|
||
| resources :users |
There was a problem hiding this comment.
Do you need all the routes for users?
| redirect_to work_path(@work.id) | ||
| else | ||
| flash.now[:alert] = @work.errors | ||
| render :new |
There was a problem hiding this comment.
You need to set @valid_categories before trying to render :new
| <% flash[:alert].each do |field, message| %> | ||
| <li> | ||
| <strong><%= field %>: </strong> | ||
| <%= message.join('') %> |
There was a problem hiding this comment.
This join is causing works error messages to crash the site.
| session[:user_id] = @user.id | ||
| flash[:success] = "Welcome back #{@user.user_name}" | ||
| else | ||
| @user = User.create user_name: params[:user][:user_name] |
There was a problem hiding this comment.
You need to check to verify that create worked! I tried to log in with a blank username and got a "welcome" message! :p
| belongs_to :user | ||
| belongs_to :work | ||
|
|
||
| validates :user, uniqueness: {scope: :work, message: "You have already voted for this title."} |
|
|
||
| def self.ordered_works(category) | ||
| works = Work.all.where(category: category).to_a | ||
| return works.sort_by {|work| -work.vote_count} |
| class Work < ApplicationRecord | ||
| has_many :votes | ||
|
|
||
| validates :category, presence: {message: "Must provide a category"} |
There was a problem hiding this comment.
I would also ensure that the category can only be, "album", "book" or "movie"
| end | ||
| end | ||
|
|
||
| describe 'ordered_works' do |
There was a problem hiding this comment.
You also need to test when:
- There are no works
- There are no votes
- One category has no votes.
| # | ||
| describe 'media_spotlight' do | ||
| it "returns the work with the higest vote count" do | ||
| Work.media_spotlight.must_equal works(:work_one) |
There was a problem hiding this comment.
Again, what happens when there are no votes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?