Ampers: Alex

[brownav]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	For works model a custom method I wrote was to generate a list of 10 works by category. That list was then sorted.
Describe how you approached testing that model method. What edge cases did you come up with?	Not too many to be honest.
What are session and flash? What is the difference between them?	Session and flash are stored as hashes. Session keeps track of a users activity and flash gives the user updates based on their actions or errors.
Describe a controller filter you wrote.	I DRYed up a bit of code but using the adding the find method for an item as a filter.
What was one thing that you gained more clarity on through this assignment?	Controllers, views, models. I need to improve on model testing.
What is the Heroku URL of your deployed application?	https://ab-mediaranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	I felt really strapped for time on this project, I need to work faster and ask for help more frequently rather than waste too much time messing around/experimenting.

[tildeee]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x
Comprehension questions	x
General
Rails fundamentals (RESTful routing, use of named paths)	x
Semantic HTML	x
Errors are reported to the user	x
Business logic lives in the models	x
Models are thoroughly tested, including relations, validations and any custom logic	didn't really test the custom logic at all
Wave 1 - Media
Splash page shows the three media categories	x
Basic CRUD operations on media are present and functional	x
Wave 2 - Users and Votes
Users can log in and log out	x
The ID of the current user is stored in the session	x
Individual user pages and the user list are present	x
A user cannot vote for the same media more than once	x
All media lists are ordered by vote count	x
Splash page contains a media spotlight	x
Media pages contain lists of voting users	x
Wave 3 - Styling
Foundation is used appropriately	x
Look and feel is similar to the original	x
Overall

Oh dang, viewing individual Work show pages doesn't work if you're not logged in! You have a huge bug surrounding all views that have a work, where some variable on the view @user is nil.

Your approach to not allowing the same user upvote the same thing more than once is fantastic! and definitely better UX ;)

You wrote a custom comparator for your Works model and I think that is RAD

Besides your major bug about users who aren't logged in, the code looks good. I wish the tests were more thorough ;) But really, the project looks and functions as expected.

Good work on this project!