Phoebe - Ampers #19

pmanni02 · 2018-04-14T03:28:53Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a method to figure out which work to put into the media spotlight. The method uses an each do loop to determine which work has the max number of votes then returns that work.
Describe how you approached testing that model method. What edge cases did you come up with?	For the spotlight method I used the edge case of if the input array is empty. An empty array would mean there are no works in the db. I tested to make sure the method returns nil. In a future iteration of this project, I would refactor the code to raise and rescue an Argument Error.
What are `session` and `flash`? What is the difference between them?	A session is hash that is stored in the browser via a cookie. Flash displays messages.
Describe a controller filter you wrote.	I wrote a filter to return the current session
What was one thing that you gained more clarity on through this assignment?	Model relationships
What is the Heroku URL of your deployed application?	https://media-pm.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Provide a few more examples of how to test model relationships.

…ng users

… pass tests

CheezItMan · 2018-04-18T17:15:20Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Check,
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	You have some unnecessary routes for votes with `upvote`
Semantic HTML
Errors are reported to the user	for the most part, if I try to login with a blank username it tells me "Welcome," but I'm not logged in.
Business logic lives in the models	Check, but see my notes in your code.
Models are thoroughly tested, including relations, validations and any custom logic	You wrote some very nice tests here!
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check, see my note in the code however.
Individual user pages and the user list are present	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Nicely done!
Look and feel is similar to the original	Looks very similar, nice work!
Overall	Really nice work, you hit all the learning goals. I left some notes in your code over minor things. Slack me if you have questions.

CheezItMan · 2018-04-18T17:02:14Z

config/routes.rb

+
+  resources :users, only: [:index, :show]
+
+  resources :votes, only: [:new, :create]


Do you need a form or a create action for votes? Wouldn't upvote do just fine?

CheezItMan · 2018-04-18T17:04:05Z

app/controllers/sessions_controller.rb

+      session[:user_id] = @user.id
+      flash[:success] = "Welcome back #{@user.name}!"
+    else
+      @user = User.create(user_params)


You should check to see if create here worked. Check to make sure validations passed!

CheezItMan · 2018-04-18T17:05:37Z

app/models/vote.rb

+  belongs_to :work
+  belongs_to :user
+
+  validates :work_id, uniqueness: {scope: :user_id}


CheezItMan · 2018-04-18T17:06:11Z

app/models/work.rb

+  validates :title, uniqueness: { scope: :category }
+  validates :published, format: { with: /\d{4}/ }, numericality: { less_than_or_equal_to: Time.now.strftime("%Y").to_i }
+
+  def self.make_category_hash


This isn't making a hash, but an array instead.

CheezItMan · 2018-04-18T17:07:05Z

app/models/work.rb

+  end
+
+  def self.spotlight
+    if Work.all != []


You should consider using an ennumerable like max_by or using ActiveRecord's .order method to do this.

or just use sort_by_vote you made below.

CheezItMan · 2018-04-18T17:10:35Z

test/models/vote_test.rb

@@ -0,0 +1,38 @@
+require "test_helper"
+
+describe Vote do


CheezItMan · 2018-04-18T17:11:32Z

test/models/work_test.rb

+      work2.valid?.must_equal true
+    end
+
+    it "is not valid when published field is not 4 digit integer <= current year" do


pmanni02 added 30 commits April 9, 2018 21:23

Initial Rails setup

5a4bd33

creates models

9acf312

adds model relationships

e6b34be

completes seeds.rb and database seeded

3b4df45

creates homepage controller and sorts works by categories

a0717db

formats works on homepage to be readable

30e4d00

limits homepage to 10 works per category

f45c92e

adds spotlight section and method template

7bcf2b0

creates work controller

5e64eaf

makes controller, routes, and index page

f1e370d

adds work index page

cd9718d

refactors work model logic

64ede75

adds show page for each work

1231e1b

adds new work form and completes new/create methods in controller

54ba5e6

adds edit form and related methods in controller

9118c6a

adds page navigation to site header

5dc4504

adds links to work show page

5eb4fec

adds delete work link/method

5edaa21

adds category selector to work partial

3ac5585

adds validations in model

f2c044d

adds validation tests to work_test

87bf587

adds category presence validation, and custom method tests

ce8ee6c

adds flash messages to work controller and app layout

24e5205

adds works to seed csv, updates work validations and tests

b2fd2ee

adds tests for #num_runs

b38b9b2

adds user seed csv and updates seed file

f7d6282

adds sessions controller

6732e2e

fills in session controller methods

5137212

adds login form, buttons, and application controller method for findi…

0c1d8c3

…ng users

fixed application controller method and user form

d033177

pmanni02 added 28 commits April 12, 2018 15:40

adds vote count to homepage

fc03572

sorts works by votes on work index and homepage

444b119

adds and sorts votes on work show page

da818dc

adds votes to user show page

b6336fd

adds to votes seed and implements logic to delete a work

b89ed56

keeps user from upvoted twice on a work

d9c4fe2

adds validation tests for vote

470e364

edits application html and saves test files

640e241

edits work and pages indexes html

d47c2b4

fixes html for add work and user index

6c11a2d

fixes html for user and work show pages

f0bf4c3

homepage html fix for heroku

cd6e24f

reverted changes for in homepage

47b0cb6

adds tests for custom work methods and modifies yml files and html to…

6d28116

… pass tests

adds title uniqueness validation to work model

bf4af56

adds test for unique title validation and cleans up other test code

f85b090

adds error messages to work create and update. edits html to show errors

ee67164

changes some messages to flash.now messages

49081e3

created must respond to tests for works

39c27e9

created must respond to tests for vote

b82cd4b

creates must respond to tests for user

ff5ce21

created migrations for removing columns from user and vote models

9c097dc

fixes date formatting and adds css styling

6322dcb

more styling

acf68dc

adds site title to chrome tab

d36a254

adds more work and vote seed data

3fb5225

fixes/sorts seed file

7c95796

code clean up

637e710

CheezItMan reviewed Apr 18, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Phoebe - Ampers #19

Phoebe - Ampers #19

Uh oh!

pmanni02 commented Apr 14, 2018

Uh oh!

CheezItMan commented Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		resources :users, only: [:index, :show]

		resources :votes, only: [:new, :create]

Phoebe - Ampers #19

Are you sure you want to change the base?

Phoebe - Ampers #19

Uh oh!

Conversation

pmanni02 commented Apr 14, 2018

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented Apr 18, 2018

Media Ranker

What We're Looking For

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Apr 18, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants