Skip to content

Conversation

@LauraAddams
Copy link

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I read the details of the query options and tested them in postman for each type of good/bad data, optional parameters, etc.
Describe your API Wrapper. How did you decide on the methods you created? My API wrapper has two main methods, search_recipes and recipe_details. The first queries using q=, later uses r=. The methods I chose are based on the descriptions from the documentation. There is an additional method(food_options) that would typically be in the model, but maybe should go elsewhere?
Describe an edge case or failure case test you wrote for your API Wrapper. Testing using bogus URIs and super bogus searches.
Explain how VCR aids in testing an API. VCRs create a 'snapshot' of API calls to use for testing, this is helpful to not overload the API request limits.
What is the Heroku URL of your deployed application? https://young-harbor-98642.herokuapp.com/

@CheezItMan
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commit and good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Very good semantic HTML
Errors are reported to the user Yes! Great work with the 404
API Wrapper to handle the API requests Check
Controller testing Check, nicely done
Lib testing Check
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab) Check
Styling
Foundation Styling for responsive layout Check
List View shows 10 items at a time/pagination Check
The app is styled to create an attractive user interface Check
API Features
The App attributes Edaman Check
The VCR casettes do not contain the API key Check
External Resources
Link to deployed app on Heroku Yep!
Overall Great work! You hit all the requirement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants