Skip to content

Conversation

@murog
Copy link

@murog murog commented Oct 2, 2017

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails In this app, Model isn't doing much besides being a class that allows me to create instance of a "Task" object in the database.
Describe in your own words what the Controller is doing in Rails The controller is performing specific tasks on Tasks objects. It creates, finds, modifies and destroys instances of Tasks.
Describe in your own words what the View is doing in Rails Renders embedded ruby and html into browser.
What is the purpose of using strong params? (i.e. the params method in the controller) Keeps specific actions private within the controller for the purpose of not having a user manipulate or create objects in ways not intended by app.
How are Rails migrations related to Rails models? The columns are attributes of the model's objects. Each row is a new instance of the model's object.
Describe one area of Rails that are still unclear on Strong params and using the update method? (Creates and saves in database?)

@CheezItMan
Copy link

Task List

What We're Looking For

Hey Guillermina,

Dee & I are switching groups for feedback and 1-1s. So I'll be doing your individual project feedback until we start JavaScript.

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Good number of commits. Good commit messages.
Answered comprehension questions Check, strong params are a way to list only specific items in params that can be accessed directly when updating a model. Also the model no the controller destroys tasks, etc. Instead the controller coordinates between the models and views and the user. Even if you're not adding much functionality to the models this time around, it's doing a lot with it's inherited functionality.
Successfully handles: Index, Show Check
Successfully handles: New, Create Check
Successfully handles: Edit, Update Check
Successfully handles: Destroy, Task Complete Check, with confirmation dialog!
Routes follow RESTful conventions Why do you have a route: get /tasks/:id/mark_complete? It's not restful or I think needed.
Uses named routes (like _path) Check
Overall Very neat how you handled sorting with a get parameter. You made good use of semantic HTML tags. The styling is nice with the post-it look. You hit all the requirements and went a bit further. Excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants