Skip to content

Conversation

@kaylaecker
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails We didn't use Models (right?), but it's where you put code to be read by the Controller
Describe in your own words what the Controller is doing in Rails Controller communicates with the Model and the View to produce the content. Also where we put the Methods for this project.
Describe in your own words what the View is doing in Rails What the user sees, like html and css
What is the purpose of using strong params? (i.e. the params method in the controller) Mass assignment protection
How are Rails migrations related to Rails models? Way to update/alter database with Active Record
Describe one area of Rails that are still unclear on The whole models/migration/etc use connection. Need more practice because I can get the concepts, but need to better put them into action.

@kariabancroft
Copy link

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Good frequent commits with meaningful messages
Answered comprehension questions You are almost always using models in Rails, and definitely in this project. They are the way you are about to interact with the data within your database. You’ll get more clarity on how this is done using migrations, but it would be a good topic for you to spend a bit more time understanding (as you noted).
Successfully handles: Index, Show index looks good. Show has a duplicate find method usage which will make an extra database call. Otherwise it looks good.
Successfully handles: New, Create Is this logic working? You’ve added a private keyword where your strong params are which means all of the controller methods below that will be “invisible”.
Successfully handles: Edit, Update Looks good
Successfully handles: Destroy, Task Complete same comment re: private keyword
Routes follow RESTful conventions Looks good! You have just one duplicate route.
Uses named routes (like _path) Yes
Overall You demonstrated the major learning goals on this assignment. Views look good. Don’t forget that when you add a class attribute to your HTML you have to put it in a string. Also, naming convention on class names is separating with a - rather than an _. FYI- your github setup is incorrect on your computer so get with myself or Charles at some point to fix this please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants