-
Notifications
You must be signed in to change notification settings - Fork 43
Pipes - Angela - Tasklist #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eate some routes.
made rudimentary views interface.
…lity e.g. controller method and link on 'index' page is written. Redirecting my work back to Wave 2 and the 'show' functionality.
…ded to DB, user is redirected to 'Home' page.
…ow' views so that the 'completed' status is a check box vs. a boolean word 'true' or 'false.'
…oring the 'Mark complete' functionality to meet requirements.
…s not saving to DB. Will work on it later.
…nges are. My belief is they are small since I lack a clear memory of the changes.
…ia migration. Now DB has all desired columns and all functionality is intact.
Task ListWhat We're Looking For
|
| get "/tasks/:id", to: "tasks#show", as: "task" | ||
| get "/tasks/:id/edit", to: "tasks#edit", as: "edit" | ||
| patch "/tasks/:id", to: "tasks#complete?", as: "complete_task" | ||
| patch "/tasks/:id", to: "tasks#update" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got the same verb/URL combo twice here! Because the router reads this file top-to-bottom looking for a match, this means the bottom route will never be used, and no request will be routed to the update action. I believe this is what's causing your update to not work.
To fix this, you would need to give the complete route a different URL - maybe /tasks/:id/mark_complete.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions