Lauren Cardella -- Carets #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date date column names to snake_case, update index view.
…e link when it is completed.
… done message if task has been marked complete.
… return to task list if succesful. Date selector is not passing due_date value to ActiveRecord.
…ms methods to controller.
…omplete. Add complete_task_path to routes. Fix complete? method in task model. Feature working.
…ate to determine status.
Task ListWhat We're Looking For
|
|
I couldn't find where the partials _complete and _incomplete were used? Good work on this overall, I'm leaving a few comments but I think overall this is great |
tildeee
reviewed
Oct 6, 2017
| <p class="task_details">Description: <%= task.description %></p> | ||
| <br> | ||
| <%= link_to image_tag("edit_pencil.png", alt: "edit button"), edit_task_path(task.id), method: :get %> | ||
| <%= link_to image_tag("delete.png", alt: "delete button"), delete_task_path(task.id), method: :delete, data: { confirm: "Delete task?" } %> |
There was a problem hiding this comment.
This confirmation alert is really cool!
tildeee
reviewed
Oct 6, 2017
| @task = Task.new(task_params) | ||
|
|
||
| if @task.save | ||
| flash[:notice] = "Task saved" |
There was a problem hiding this comment.
nice use of flash, but you don't end up using this at all in the view!
We'll be going over flash formally next week
Author
There was a problem hiding this comment.
I was wondering why it wasn't showing...
tildeee
reviewed
Oct 6, 2017
| def destroy | ||
| Task.find_by(id: params[:id]).destroy | ||
|
|
||
| redirect_to root_path, notice: "Task deleted." |
There was a problem hiding this comment.
Cool that you're setting notice, but this doesn't end up getting used on the view at all
Author
|
I didn't end up using the _incomplete and _complete partials, then forgot to delete the files 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions