Skip to content

Conversation

@canaanwest
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model holds all of the data and the bulk of the business logic for a rails app
Describe in your own words what the Controller is doing in Rails the controller communicates between the view and the controller.
Describe in your own words what the View is doing in Rails the view displays information to the user
What is the purpose of using strong params? (i.e. the params method in the controller) Strong params prevent users from accidentally modifying a database by only allowing access to some params and protecting the others
How are Rails migrations related to Rails models? Migrate makes modifications to the database schema
Describe one area of Rails that are still unclear on The process of setting up the database is still a little foggy.

@CheezItMan
Copy link

Task List

What We're Looking For

Hello Canaan,

Dee & I are switching off feedback & 1-1s for the Rails unit, so I'll be doing your project feedback & 1-1s until JavaScript.

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Arg! not enough commits! Also the commit messages don't convey the functionality finished.
Answered comprehension questions Check, It' normal for the database portion to be foggy as Rails does so much for you. Also Strong params prevent the user for modifying the database on purpose instead of accidentally. Also the Model handles communication with the Database, Postgres in our case.
Successfully handles: Index, Show Check
Successfully handles: New, Create Check
Successfully handles: Edit, Update Check
Successfully handles: Destroy, Task Complete Check
Routes follow RESTful conventions Check
Uses named routes (like _path) Check
Overall Let me say I love the styling. You hit all the requirement and did them well. I did leave some suggestions in your code, you can see them under the file changed tab.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments

end

def show
@task = Task.find(params[:id].to_i)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's is best-practice to have an action ready if you can't find the task represented by the id. This applies to edit, create, update, delete, and mark_unmark actions.

end

def create
@task = Task.new(name: params[:task][:name], description:params[:task][:description], due:params[:task][:due], status: "incomplete")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good place to use task_params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants