-
Notifications
You must be signed in to change notification settings - Fork 43
canaan - carets #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
canaan - carets #34
Conversation
Task ListWhat We're Looking ForHello Canaan, Dee & I are switching off feedback & 1-1s for the Rails unit, so I'll be doing your project feedback & 1-1s until JavaScript.
|
CheezItMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments
| end | ||
|
|
||
| def show | ||
| @task = Task.find(params[:id].to_i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's is best-practice to have an action ready if you can't find the task represented by the id. This applies to edit, create, update, delete, and mark_unmark actions.
| end | ||
|
|
||
| def create | ||
| @task = Task.new(name: params[:task][:name], description:params[:task][:description], due:params[:task][:due], status: "incomplete") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good place to use task_params.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions