-
Notifications
You must be signed in to change notification settings - Fork 43
Jan Edrozo | Carets #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… and added box border
Task ListWhat We're Looking ForHello Jan, Dee & I are switching off feedback and 1-1s for the Rails unit. So I'll be doing all your solo project feedback.
|
CheezItMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
| @@ -0,0 +1,46 @@ | |||
| <!-- home right navigation links --> | |||
| <nav class="tasklist-nav"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This nav, should be in the layout file.
| <header> | ||
| <h1><%= link_to("TASKLIST", root_path, alt: 'homepage')%></h1> | ||
| </header> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good place to put the site navigation...
app/views/tasks/index.html.erb
Outdated
| <%= link_to("Edit", edit_task_path(task.id), class: 'no-underline') %> | | ||
| </div> | ||
| <div class="task-options-button"> | ||
| <%= link_to('Delete', delete_task_path(task.id), method: :delete, data: {confirm: "Are you sure you would like to delete this task?"}, class: 'no-underline') %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of the confirmation message.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions