Skip to content

Conversation

@JNEdrozo
Copy link

@JNEdrozo JNEdrozo commented Oct 1, 2017

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The Model contains data for the application (usually linked to a database) and the state of the application; it also contains all the business logic to dictate how app interacts with its database.
Describe in your own words what the Controller is doing in Rails The Controller responds to the client's HTTP requests using the routes from the routes.rb file which in turn provide views and/or actions for the client.
Describe in your own words what the View is doing in Rails The View handles all user interface responsibilities to present data to the user based on the controller's actions.
What is the purpose of using strong params? (i.e. the params method in the controller) Strong parameters boost security and prevent any malicious activity with user input. "With strong parameters, Action Controller parameters are forbidden to be used in Active Model mass assignments until they have been whitelisted. This means that you'll have to make a conscious decision about which attributes to allow for mass update. This is a better security practice to help prevent accidentally allowing users to update sensitive model attributes." (http://guides.rubyonrails.org/action_controller_overview.html#strong-parameters)
How are Rails migrations related to Rails models? Migrations allow you to alter your model's schema and make changes to the database; where each migration becomes a 'version' of the database. A schema starts off with nothing in it, and each migration modifies it to add or remove tables, columns, or entries.
Describe one area of Rails that are still unclear on There's a lot, but one area I'd like to get more clarity would be on best practices for styling my rails app with css.

@CheezItMan
Copy link

Task List

What We're Looking For

Hello Jan,

Dee & I are switching off feedback and 1-1s for the Rails unit. So I'll be doing all your solo project feedback.

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in Good number of commits, but keep your commit messages focused on functionality added rather than waves.
Answered comprehension questions For styling, I'm not the greatest expect, but I would suggest putting your styling in the application.css file and trying to make each of your pages to look as consistent as possible. Other than that it's just like styling an HTML app. Well aside from Sassy CSS.
Successfully handles: Index, Show Check
Successfully handles: New, Create Check
Successfully handles: Edit, Update Check
Successfully handles: Destroy, Task Complete
Routes follow RESTful conventions Check
Uses named routes (like _path) Check
Overall I would suggest using the date widget for the completion date or due date field. Also I would place things like the menu in the layout file instead of in the index view. However you hit all the requirement, well done.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

@@ -0,0 +1,46 @@
<!-- home right navigation links -->
<nav class="tasklist-nav">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nav, should be in the layout file.

<header>
<h1><%= link_to("TASKLIST", root_path, alt: 'homepage')%></h1>
</header>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good place to put the site navigation...

<%= link_to("Edit", edit_task_path(task.id), class: 'no-underline') %> |
</div>
<div class="task-options-button">
<%= link_to('Delete', delete_task_path(task.id), method: :delete, data: {confirm: "Are you sure you would like to delete this task?"}, class: 'no-underline') %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the confirmation message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants