-
Notifications
You must be signed in to change notification settings - Fork 43
Jocelyn Gonzalez -- Carets #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Task ListWhat We're Looking ForHello Jocelyn, Dee & I are switching groups for feedback and 1-1s for the Rails unit. So I'll be doing your project feedback and 1-1s until we start Javascript.
|
CheezItMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
| end | ||
|
|
||
| def show | ||
| @task = Task.find( params[:id] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to have some sort of if statement here to handle the occasions where, you can't find the given task. This also applies to delete, create, update, edit, etc.
| end | ||
|
|
||
| def create | ||
| @task = Task.new(name: params[:task][:name], description: params[:task][:description], completion_date: params[:task][:completion_date]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good use-case for strong params.
| <h1> | ||
| TaskList | ||
| </h1> | ||
| <div class="clearfix"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "navigation" section would make sense to have as part of the layout.
Also maybe instead of div use nav.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions