-
Notifications
You must be signed in to change notification settings - Fork 43
Task List - Marisa Morris - Carets #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Task ListWhat We're Looking For
|
| </div> | ||
|
|
||
| <div> | ||
| <img class="gif" src="https://media.giphy.com/media/YLHwkqayc1j7a/200.gif" alt="jafar gif"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the best
|
Good job overall meeting the requirements for this project! Just a few comments:
|
| <!-- <%= task.name %> --> | ||
|
|
||
| <div class="task_name"> | ||
| <%= "#{counter}. " %> <%=link_to(task.name, task_path(task.id)) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using a counter variable, you could probably just make this list an ordered list (
- instead of
- ) and leave your list-style style alone (remove line 89 on tasks.scss)
| </ul> | ||
| </div> | ||
|
|
||
| <div class="'left_options'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this use of double quotes and single quotes intentional?
| <h4>Completion Date: <%= @task[:completion_date] %></h4> | ||
|
|
||
| <% else %> | ||
| < h1>404: Not Found</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll talk about formally receiving a 404 HTTP Status request soon in the future!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's invalid html to have a space in that tag (you wrote < h1>, it should be <h1>
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions