Skip to content

Conversation

@marisamorris
Copy link

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe in your own words what the Model is doing in Rails The model represents data.
Describe in your own words what the Controller is doing in Rails The controller interprets user action and provides model data to the view.
Describe in your own words what the View is doing in Rails The view displays model data and sends user action to the controller.
What is the purpose of using strong params? (i.e. the params method in the controller) The purpose of using strong params is to mark things as safe or required and choose what can be updated in addition to preventing users from potentially updating sensitive model attributes.
How are Rails migrations related to Rails models? Rails migrations generate models and create/update table schema
Describe one area of Rails that are still unclear on Im unclear on why deleting a task does not shift the remaining tasks up and update the id numbers. For example, if I have two tasks and delete the second and then create a third, the third task will have an ID of three instead of two.

@tildeee
Copy link

tildeee commented Oct 6, 2017

Task List

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in x
Answered comprehension questions x
Successfully handles: Index, Show x
Successfully handles: New, Create x
Successfully handles: Edit, Update x
Successfully handles: Destroy, Task Complete x
Routes follow RESTful conventions x
Uses named routes (like _path) x
Overall

</div>

<div>
<img class="gif" src="https://media.giphy.com/media/YLHwkqayc1j7a/200.gif" alt="jafar gif">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the best

@tildeee
Copy link

tildeee commented Oct 6, 2017

Good job overall meeting the requirements for this project!

Just a few comments:

  • You didn't make too much progress in styling your project, which is fine and optional! Just an observation
  • There's a chance to refactor and use view partials for your new task view and edit task view

<!-- <%= task.name %> -->

<div class="task_name">
<%= "#{counter}. " %> <%=link_to(task.name, task_path(task.id)) %>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using a counter variable, you could probably just make this list an ordered list (

    instead of
      ) and leave your list-style style alone (remove line 89 on tasks.scss)

</ul>
</div>

<div class="'left_options'">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this use of double quotes and single quotes intentional?

<h4>Completion Date: <%= @task[:completion_date] %></h4>

<% else %>
< h1>404: Not Found</h1>
Copy link

@tildeee tildeee Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll talk about formally receiving a 404 HTTP Status request soon in the future!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it's invalid html to have a space in that tag (you wrote < h1>, it should be <h1>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants