Skip to content

Conversation

@SaraChandler
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had forgotten that article tags needed titles and tried to use them without an h tag. I opted to replace the article tag with separate ids.
Why is it important to consider and use semantic HTML? Writing semantic HTML allows you to be more accurate with styles in your CSS. Inline styling in HTML prevents the addition of greater specificity and significance to your content.
How did you decide to structure your CSS? I decided to mostly write the CSS following the structure of the HTML -- from top to bottom.
What was the most challenging piece of this assignment? Finding time to write in website content. Also choosing a layout.
Describe one area that you gained more clarity on when completing this assignment My understanding of how to position blocks around the page increased and I found it easier to manipulate content.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage More commits would have been better, but it's hard with HTML/CSS. Good commit messages.
Answered comprehension questions Check, Semantic HTML isn't the same as avoiding inline styling. Instead it refers to tags that convey meaning to their contents. So using section, article, main, header, footer, nav, etc. I'm glad your understanding of layout improved.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main Very good use of semantic HTML.
Appropriately using semantic tags: section, article, etc. Check
All images include alternate text Check
CSS
Using class and ID names in style declarations Good use of class attributes, no ID tags, but that's unneeded.
Style declarations are DRY You have two header selectors in about-styles.css. There are some other areas where you could DRY up your code such as repeated uses of the rule, float: right; etc, but that's mostly a nitpick.
Overall Your site looks really great! I like the look and the use of images. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants