Skip to content

Conversation

@VirtualLindsey
Copy link

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? part of creating an object
Describe an instance variable you used and what you used it for. @planet to store information about one planet
Describe what the difference would be if your SolarSystem used an Array vs a Hash. iteration will work differently
Do you feel like you used consistent indentation throughout your code? yes

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & the template questions answered. Mostly - Please be more specific when answering comprehension questions.
Wave 3 is incomplete, making this submission not meeting expectations for this project. You may demonstrate comprehension of the material by resubmitting the project and emailing Dan or myself. Please ask either of us if you need help or clarification with anything.
Additional Feedback
displaying planets return_attribute method should belong to the Planet class. Then, SolarSystem's return_print method should call planet's return_attribute instead of making a new string with planet's information.
Got an error when I ran the code. There was an extra end in return_attribute method. An error like that should be found and removed before submitting.
SolarSystem's @planet variable implies that it is storing a single planet. @planets is more appropriate to imply that it is holding a collection.
wave 3 code, is not working because the print_planet_att(planet_choice) method does not exist on the SolarSystem class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants