Skip to content

Conversation

@SRBusiness
Copy link

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? in the solar systems class the initialize method is a constructor that reads in the parameter of planets and creates the instance of my class.
Describe an instance variable you used and what you used it for. In my Solar_system class the single instance variable I used was @planets which was used to store instances of the attribute planets. @planets was an array of hashes that stored instances of my Planets class.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. Using a hash the planets were unordered compared to the ordered nature of the array. So when we called planets in the array we needed to call it in order based on the index of the array. If we were going to call from the hash we would have needed to match based a key/value pair.
Do you feel like you used consistent indentation throughout your code? I have atom to set up show to me the hidden indentation/spacing lines and I have a linter installed which angrily underlines things when the indentation or spacing is incorrect. With those those atom features set up I feel like it is very easy to have consistent indentation and spacing.

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & the template questions answered. Well Done - one thing, by wave 3 @planets was an array of planet objects. There are no more hashes after wave 2, since the Planet objects replaced the hashes from wave 1.
Submission meets project expectations.
Additional Feedback
Data Types Instead of having all planet data as strings, choose a consistence measurement for anything numeric based (like years or distance) and use either Integer, Float or DateTime objects. That way it will be much more efficient to perform any math.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants