Skip to content

Conversation

@swubeshet
Copy link

@swubeshet swubeshet commented Aug 16, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? It jumpstarted started the instance variables that are used
Describe an instance variable you used and what you used it for. @name, I used it to call a name
Describe what the difference would be if your SolarSystem used an Array vs a Hash. A hash would be easier to call due to the keys, whereas an array are ordered.
Do you feel like you used consistent indentation throughout your code? Yes. But I had a really hard time understanding classes and objects, so this assignment is not done correctly at all. I hope to come back to it once I have a better understanding of what I am doing and will resubmit it. Thanks.

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Mostly - Planet objects should have 5 attributes
Used an Array to store a list of planets in the SolarSystem class. Needs Improvement - SolarSystem class is setup where the variable implies that it would take a collection of Planets, but I do not see any instances of SolarSystem being made to know for sure that it is going to do that. The SolarSystem class should have the methods that add a planet and to iterate though a collection of Planet objects to display each planet's attributes.
Readable code with consistent indentation. Needs Improvement - any code within a method definition should be indented.
Created a pull request with your name & the template questions answered. Almost - Please be more specific with responses, where did you call @name. In what context would the hash keys be better? ect.
❗️__Submission does not meet expectations. Please review the feedback and ask for any clarification. You can resubmit this project and email Dan or Jamie.__
Additional Feedback
Planet Attributes A single planet should not be responsible for having a collection of other Planets. Making @all_planets an inappropriate attribute for Planet class. Only SolarSystem should be responsible for having a collection of Planets.
Planet Behavior The SolarSystem is the only class that should have a collection of Planet objects, therefore it should be the only class that has a method to add a planet and show all planet's information.
Planet return_att method It does not need a counter, it is not iterating or working with more than one thing. There should be a method in SolarSystem that iterates though and adds the number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants