Skip to content

Conversation

@SesameSeeds
Copy link

@SesameSeeds SesameSeeds commented Aug 16, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? If I understand this properly, the purpose was to initialize all of the data for each planet, so it can pull up all the details.
Describe an instance variable you used and what you used it for.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. It may be more fluid, I'd have to call the number versus symbols I suppose. I mean I used an array of hashes as I didn't get very far and for that I apologize.
Do you feel like you used consistent indentation throughout your code? I think I have that down now... Thanks command, alt, L.

Please note, I still find this entire concept extremely confusing, I had to get some assistance and used google and youtube to just make this work. I am going to be getting tutoring on this today, it made answering these questions very difficult though I feel like it shouldn't be. I would like to submit an edited version after tutoring and visiting through these concepts and have that looked at. I do apologize that this is so poorly done/understood (like putting just data in, literally the word data...), I ran out of time/patience.

@SesameSeeds SesameSeeds changed the title Add files via upload Stef Gunderson -- Solar System (needs work) -- Carets Aug 16, 2017
@SesameSeeds SesameSeeds changed the title Stef Gunderson -- Solar System (needs work) -- Carets Stef Gunderson -- Carets Aug 16, 2017
@CheezItMan
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Check, very nicely done!
Used an Array to store a list of planets in the SolarSystem class. Check!
Readable code with consistent indentation. Check, cmd-alt-l works!
Created a pull request with your name & the template questions answered. Check
Summary Well done, I can see the progress you & Charles made. I'm glad the tutoring is helping. Let me know if you want me to review anything with future projects as you work. I would suggest 1 thing, renaming the Planet class' attributes to to_s just so you can directly puts mercury and get the planet to print. Still looks awesome, very well written and very DRY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants