Skip to content

Conversation

@skwiens
Copy link

@skwiens skwiens commented Aug 16, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? Solar_System: create an instance variable the array of planets, create an instance variable with an array of planet names, create an instance variable for the solar system age. Planet: Create instance variables for all the input attributes.
Describe an instance variable you used and what you used it for. Several times I used a planet variable name set to an instance of a planet. I used this to input planet instances that could call tehir own information from within the solar system.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. The difference would be how the user inputed the information into solar system... as an array or as a hash.
Do you feel like you used consistent indentation throughout your code? Maybe?

@CheezItMan
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Check
Used an Array to store a list of planets in the SolarSystem class. Check, but do you need @num_of_planets? You could simply use planets.length. Also why use @planet_names? A Planet should probably store it's own name.
Readable code with consistent indentation. You did, I checked ;)
Created a pull request with your name & the template questions answered. Check
Summary Very well done, good work with the interactivity and the other extras. Nice work using a hash to initialize planets. You hit all the requirements and the extras. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants