Skip to content

Conversation

@nkiruka
Copy link

@nkiruka nkiruka commented Aug 16, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? Once a new object is created, it is initialized and ready to be used in the class methods available to it.
Describe an instance variable you used and what you used it for. @planets, which was an array that was initialized in the initialize method. For instance, when I created an instance of the SolarSystem, I passed an array of planets. The object type (array) was passed into the initialize method and saved to the @planets instance variable.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. The major difference I observed is the difference in iterating over an array vs. a hash. For instance, iterating over an array of a hash, involves accessing the array first, then calling an each method on each hash in the array to get a print out of the planet and it's attributes (key, value pair).
Do you feel like you used consistent indentation throughout your code? I think my code can still be cleaner.

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & the template questions answered.
❗️ The work you have submitted is well done. However,Wave 3 is missing, making this project incomplete and not meeting expectations for this project. You may complete the final wave and email Dan or myself to review.
Additional Feedback
Data Types All of planet's attributes are strings. What would be more appropriate for "4222", "2", "6.42"? If you have standalone numbers like that, Integer or Float is more appropriate. That way you can perform math on those values, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants