Skip to content

Conversation

@LauraAddams
Copy link

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? To create initial data for the class/methods.
Describe an instance variable you used and what you used it for. Like @planets, created after a .new? I used it like in SolarSystem.new(planets_array) to store the planets in my class.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. Currently its an array of variable; if it was a hash, you'd have to use [:name] etc, and call to the planets class in addition like. @planets[0].spaceorbs[:name] or something similar.
Do you feel like you used consistent indentation throughout your code? Yes

@CheezItMan
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Check
Used an Array to store a list of planets in the SolarSystem class. Check
Readable code with consistent indentation. Check
Created a pull request with your name & the template questions answered. Check
Summary The names of your methods are kinda funny, spaceorbs. The comparison method is a bit odd. Since you're comparing it to the distance of the greatwall, it should probably be named something a bit clearer. In terms of organization, I would separate method which read user input from methods that do things like add planets to the solar system. The numbers in your list confused me at first as well, it took me a minute to realize that I needed to type the planet's full name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants