Skip to content

Conversation

@lmarianarp19
Copy link

@lmarianarp19 lmarianarp19 commented Aug 16, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? To establish the arguments of the class
Describe an instance variable you used and what you used it for. My Planets class has a satellites instance variable that store the amount of planet's satellites.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. I find easier to add new planets to the Array than to the Hash, with the hash I need to give a key for the planet.
Do you feel like you used consistent indentation throughout your code? Yes

@PilgrimMemoirs
Copy link

Solar System

What We're Looking For

Feature Feedback
Created Custom Class with initialize method & instance variables. Well Done
Used an Array to store a list of planets in the SolarSystem class. Well Done
Readable code with consistent indentation. Well Done
Created a pull request with your name & the template questions answered. Well Done - For clarification with initialize, to establish the arguments as what? A good way to put that would be to set the state of the instance or establish the instance variables of that object.
Submission meets project expectations.
Additional Feedback
Data types When creating the instances of planet, all data provided are strings. Some of those, the numeric ones, would be more appropriate as integers or floats. As long as the measurement is consistent, like days or miles, than you only need to store the number. For clarification you can add the measurement as part of the variable, like @miles_from_sun or @days_in_a_year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants