forked from AdaGold/BankAccounts
-
Notifications
You must be signed in to change notification settings - Fork 26
Waves 1-3 of BankAccounts #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlikesplants
wants to merge
24
commits into
Ada-C5:master
Choose a base branch
from
jlikesplants:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to return balance at any time.
Added ArgumentError when user tries to initialize new Account with a negative balance. Added warning message and abort withdrawal when user tries to overdraw account. Tracking @init_balance and @balance in separate variables so user can go back and look at their initial balance, and so the code looks cuter (seeing @init_balance all the time = bothersome).
This allows the user to instantiate an Owner and then associate that owner with an already existing instance of Account.
Also started working to associate owner data, owner_account data, and account data. WHEW.
…ods to store the withdrawal fee and calculate the minimum checking balance that is okay for a withdrawal.
…ved Checking Account withdrawal method.
…message and removed overridden withdrawal method from SavingsAccount class.
…nt MIN_NEG_MSG (line 154) - how to interpolate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed by me, with help from Adies :-)
Dependencies: require CSV, require AwesomePrint
This was a fun one- I enjoyed going back through and trying to refactor using super and constants and inheritance.