Open
Conversation
kaidamasaki
reviewed
Nov 13, 2021
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Great job!
I left a couple of style notes but overall everything looks good! Well done!
Comment on lines
+108
to
+121
| # @task_bp.route("/<task_id>", methods=["GET"]) | ||
| # def handle_task(task_id): | ||
| # task_id = int(task_id) | ||
| # task = Task.query.get(task_id) | ||
| # if not task: | ||
| # return make_response(f"Task {task_id} Bad data", 400) | ||
|
|
||
| # if request.method == GET | ||
|
|
||
| # for task in tasks: | ||
| # if task.id == task_id: | ||
| # return vars(task) | ||
|
|
||
| # return "Not found", 404 |
There was a problem hiding this comment.
Style: Clean up commented out code.
| try: | ||
| int(number) | ||
| except: | ||
| abort(make_response({"error": f"{parameter_type} must be an int"})), 400 |
There was a problem hiding this comment.
I like that you included a parameter name in the message!
| goal_id = int(goal_id) | ||
| goal = Goal.query.get(goal_id) | ||
| if goal is None: | ||
| return make_response("", 404) |
There was a problem hiding this comment.
It's helpful to provide detailed error messages for debugging:
Suggested change
| return make_response("", 404) | |
| return make_response({"error": f"Could not find goal #{goal_id}"}, 404) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.