Conversation
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
🌸 Most of your implementation was quite solid, Kayla! However, your implementation missed updating the attributes your Node class had to accommodate a doubly linked list. Additionally, as only one time and space complexity question was filled out, I will be marking this as a yellow. Let me know what questions you have!
🟡
| # returns None if the list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first(self): |
There was a problem hiding this comment.
✨ Your implementation is solid, but time and space complexity?
| def __init__(self): | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.head = None # keep the head private. Not accessible outside this class | ||
| self.tail = None |
| if self.head is None: | ||
| self.head = self.tail = Node(value) | ||
| else: | ||
| new_Node = Node(value, self.head) |
There was a problem hiding this comment.
Remember our Python style conventions!
| new_Node = Node(value, self.head) | |
| new_node = Node(value, self.head) | |
| class Node: | ||
|
|
||
| def __init__(self, value, next_node = None): | ||
| def __init__(self, value, next_Node = None): |
There was a problem hiding this comment.
With Python Pep8 style conventions, we'd like our variables to be all lowercase. You also use previous in your methods below, but no attribute previous exists.
| def __init__(self, value, next_Node = None): | |
| def __init__(self, value, next_node = None, previous_node = None): | |
| def __init__(self, value, next_Node = None): | ||
| self.value = value | ||
| self.next = next_node | ||
| self.next = next_Node |
There was a problem hiding this comment.
| self.next = next_Node | |
| self.next = next_node | |
| self.previous = previous_node | |
| # returns None if the linked list is empty | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last(self): |
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def add_last(self, value): |
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
| # method to delete the first node found with specified value | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def delete(self, value): |
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse(self): |
2 participants
No description provided.