-
Notifications
You must be signed in to change notification settings - Fork 51
Algorithms-Python #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ro, I'm marking this project as a yellow since time and space complexity are missing and that's something we'd really like to think about with dynamic programming. A yellow is a passing score so resubmission is not required, but you are free to resubmit with the time and space complexity filled out for a green score. Let me know what questions you have
🟡
| @@ -7,6 +7,16 @@ def max_sub_array(nums): | |||
| """ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Implementations looks great, but what about time and space complexity?
| Time Complexity: ? | ||
| Space Complexity: ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Implementation looks mostly good again here, but what about time and space complexity?
| current_list.append(current_list[current_list[count - 1]] + current_list[count - current_list[count - 1]]) | ||
| count += 1 | ||
|
|
||
| return [str(item) for item in current_list] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 To pass the tests, you want to return the newman conway numbers as a string (ex. "0 1 1") instead of a list of strings
No description provided.