Skip to content

Branches - Xinran#50

Open
gracexinran wants to merge 1 commit intoAda-C12:masterfrom
gracexinran:master
Open

Branches - Xinran#50
gracexinran wants to merge 1 commit intoAda-C12:masterfrom
gracexinran:master

Conversation

@gracexinran
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox For the last section of Support and About
Describe a time you chose to use CSS Grid For the two div in the last section (Support and About)
What was a challenge you overcame in this project? Align the first list in nav bar left and the other two lists right
What concept did you get the most clarity on through Startrly? position: fixed to fix the nav bar

Copy link

@TiffanyChio TiffanyChio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! I am VERY impressed with how succinct and DRY your code is. Your project looks exactly the same as the wireframe! I did have some trouble figuring out what part of the HTML I was on with the use of nth-of-type selectors. I'm not sure if using classes and ids may result in a trade off where your code becomes less DRY but easier to read. So maybe that's not a trade-off you would want to make. But again, such a great job! Your organization and logical reasoning skills must be off the charts!!

background-color: rgb(247, 239, 227);
}

body>div {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way of keeping your positioning code DRY!

border-bottom: 1px solid black;
}

nav ul {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider a background-color for nav? It's not necessary but would make it easier to see the nav texts over the texts "below" it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants