Skip to content

Steph Garcia-Branches#47

Open
Steph0088 wants to merge 1 commit intoAda-C12:masterfrom
Steph0088:master
Open

Steph Garcia-Branches#47
Steph0088 wants to merge 1 commit intoAda-C12:masterfrom
Steph0088:master

Conversation

@Steph0088
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox
Describe a time you chose to use CSS Grid
What was a challenge you overcame in this project?
What concept did you get the most clarity on through Startrly?

Copy link

@idhallie idhallie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steph - Even though you didn't quite get all the way through this project, you came up with some clever solutions to formatting and I learned some new things from you!

Thanks for letting me peek at your code.
-Hallie

body{
background: lemonchiffon;
}
.container{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever way to use flex in the nav! I really like how you adjusted the margins with em to align the words where they needed to go.

align-items: center;
flex-direction: column;
justify-content: space-between;
padding: 10mm;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! I think there was a typo here--should be em instead of mm.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait! I could be wrong. mm might be a think.

padding: 0;
}

.second-container sub{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the example each word in this sub is capitalized. You could use the text-transform: capitalize property to do that.

.button{
border-radius: 15px;
background-color: lightblue;
border: grey;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'd be able to delete this line since the next line also gives you the grey border.

font-size: 1.3em;
}

#start-quote{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool find on how to add the quotes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants