Open
Conversation
mfunkemomo
reviewed
Sep 20, 2019
mfunkemomo
left a comment
mfunkemomo
left a comment
There was a problem hiding this comment.
Wonderful! I can learn a lot about grid from your code (I may it as reference later hehehe). Definitely give flexbox a try in future projects. It'll help when you need to wrap items for mobile view!
| <h1>Startrly</h1> | ||
| <sub>A catchy tagline for a great solution</sub> | ||
| <sub class="phrase">A catchy tagline for a great solution</sub> | ||
| <div class="button"> |
There was a problem hiding this comment.
Nice! This makes it clear that it's a button.
| <span>CIO</span> | ||
| </li> | ||
| <li> | ||
| <li id=charles> |
There was a problem hiding this comment.
Missing quotes but I love how you gave every person an id.
|
|
||
|
|
||
| <section> | ||
| <section class="section8"> |
There was a problem hiding this comment.
I noticed you gave sections an id and called it 'section#'. I think it'd be more meaningful to name each section based on what it is.
| font-family: Arial, Helvetica, sans-serif; | ||
| } | ||
|
|
||
| .general { |
There was a problem hiding this comment.
I love this! You broke the entire page down into sections so it would be easier to use later.
| } | ||
| .section2 { | ||
| grid-row-start: 2; | ||
| background-image: url("background.jpg"); |
|
|
||
| .section4 .types .text-image { | ||
| display: grid; | ||
| grid-template-columns: repeat(2, 1fr); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions