Conversation
|
Cloned the wrong repo and had to copy+paste code into this repo! |
njch5
left a comment
njch5
left a comment
There was a problem hiding this comment.
Awesome job!! I really like the colors on your Startrly site and how you arranged the why and team images/text (definitely not an easy feat!). I left some minor suggestions on your code, but overall great job! :)
| content: "-- " | ||
| } | ||
|
|
||
| .why-class { |
There was a problem hiding this comment.
Great job getting the 3 boxes in the same line!! 👍
| background: #FFBCB5 | ||
| } | ||
|
|
||
| .sponsors-class h2 { |
There was a problem hiding this comment.
I noticed on line 17 that you set all the h2 font-sizes to be 3em. Was it intentional to make .sponsors-class h2 smaller than the other sections'? If not, I think this entire selector could be removed.
| background-color: #F2E5D7; | ||
| padding: 4em 4em; | ||
| max-height: 15em; | ||
| font-size: 1em; |
There was a problem hiding this comment.
Minor suggestion: the font-size could be 2em so that both quotes are slightly bigger in each section.
| text-align: center; | ||
| } | ||
|
|
||
| nav li:hover { |
There was a problem hiding this comment.
I love the color contrast between the links and the hover color!
|
|
||
| @media only screen and (max-width: 600px) { | ||
| .why-class img { | ||
| display: none; |
There was a problem hiding this comment.
It's really cool how you wrote this media query. I tested it in Chrome's developer tools and it works!
| background: #3C6E71; | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| justify-content: flex-start; |
There was a problem hiding this comment.
| justify-content: flex-start; | |
| justify-content: flex-start; | |
| padding-left: 5em |
Minor suggestion: you could align the footer links with Startrly (the one at the top) by adding padding-left.
changed file path (because this was copy+pasted)
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions