Skip to content

Leaves - Emily V#41

Open
emilyvomacka wants to merge 1 commit intoAda-C12:masterfrom
emilyvomacka:master
Open

Leaves - Emily V#41
emilyvomacka wants to merge 1 commit intoAda-C12:masterfrom
emilyvomacka:master

Conversation

@emilyvomacka
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox
Describe a time you chose to use CSS Grid
What was a challenge you overcame in this project?
What concept did you get the most clarity on through Startrly?

Copy link

@dora1405 dora1405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is very responsive -- so awesome! Nice use of flexbox and grid. Only a few details and those can easily be done by using grid vs flexbox and modifying the container.

}

nav ul {
display: flex;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome use of flex! Grid can also be used if you want to move one of the list to the left side more.

ul {
list-style: none;
padding: 0;
margin-bottom: 100px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I didn't know you can target the top/bottom specifically.

}

blockquote::before {
content: "\""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great insertion of quotes symbol around the quotes.

text-align: center;
}

#team img {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding can be added to get that whitespace between the image and the border.

border-width: 2px;
}

#one {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of grid! To get the images in tighter together, you can manipulate the width of the container.


}

#sub {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add font-weight to bold this text. Can also use font-size to make it larger.

content: "--"
}

.why {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of flex to make the text wrap around the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants