Skip to content

Leave - Alice#39

Open
sun-alice wants to merge 2 commits intoAda-C12:masterfrom
sun-alice:master
Open

Leave - Alice#39
sun-alice wants to merge 2 commits intoAda-C12:masterfrom
sun-alice:master

Conversation

@sun-alice
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox I chose to use flexbox on the navbar, and chose to have all of the items default to the right side, and then to have just the title default to the left, in order to get that separation on it.
Describe a time you chose to use CSS Grid I chose to use grid on the "why" section, because I wanted it to line up in a row.
What was a challenge you overcame in this project? A challenge I overcame was trying to arrange the "why" ul in a row. I originally had it displayed as flex, but it wouldn't line up in a straight line. I then decided to try and use grid, and it lined up!
What concept did you get the most clarity on through Startrly? I got most concept out of using flex, as I was trying to use it the most. I was able to see how it really works on a site, and manipulate items with it to get it where I wanted it to be.

Copy link

@rinostar rinostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomesauce! 💃

<meta charset="utf-8">
<title>Startrly</title>
<link href="styles/styles.css" rel="stylesheet">
<link href="styles/normalize.css" rel="stylesheet">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great order! (it matters :)



<section>
<section class="quote">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you utilized id for specific sessions and class for common sections.

font-family: 'Roboto', sans-serif;
}

ul {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to get rid of bullet points for all ul here 👍

margin-top: 3vw;
}

h2:hover {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total personal opinion: I think it might makes to add hover effect to the navigation bar :)

font-size: 1.5vw;
justify-content:flex-end;
font-weight: bold;
background:lightgrey;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how we both applied KonMari method to styling here: keep it simple and joyful ~

}

#navbar li {
padding: 3vw;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And stealing this too <3 <3

margin-top: 20vw;
}

#title a{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Some Call to Action" button became two lines when you max the screen size - I don't know how to fix it, but think it would worth to look into :)

margin-bottom: 8vw;
}

#why img{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images and text under "Why?" looks kinda funky when you half size the page - Again, I'm also still try to figure out the best way to adjust to screen size changes :)

}

#team span{
display: block;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOOOO good

section:last-of-type {
display: grid;
align-items: start;
grid-template-areas: "a b c c" "a b c c";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspicious if this session is doing anything ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants