Conversation
mdove92
left a comment
mdove92
left a comment
There was a problem hiding this comment.
Your website is so pretty! Great use of pseudo elements and calling out children!
My only main comment is that you could use very explicitly named classes and IDs to make it clearer to what your CSS file is referring to in your HTML. Also, feel free to use margins and width/heights to adjust the look of your elements.
It looks great! nice work on your pretty web page. Great design choice.
| @@ -0,0 +1,184 @@ | |||
| .container { | |||
There was a problem hiding this comment.
I love your use of container to call out specific elements and to avoid repeated code.
| } | ||
|
|
||
| #startly sub { | ||
| min-height: 30px; |
There was a problem hiding this comment.
Maybe you could use a relative measurement here to avoid strange spacing when adjusting a window?
| font-size: 1.5rem; | ||
| } | ||
|
|
||
| #startly a { |
There was a problem hiding this comment.
Clearer class and ID names might help a reader to know where in index.html we are formatting with the code. For example instead of #startly a it could be named .tagline #action.
|
|
||
| .section_ p { | ||
| text-align: right; | ||
| padding: 0px 8% 0px 0px; |
There was a problem hiding this comment.
When doing measurements for the same element, it might be more readable to use a consistent unit, such as all pixels, or all percentages.
| .team { | ||
| display: flex; | ||
| /* flex-wrap: wrap; */ | ||
| align-items: flex-start; |
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions