Conversation
| /** | ||
| * 1. Correct the line height in all browsers. | ||
| * 2. Prevent adjustments of font size after orientation changes in iOS. | ||
| */ |
There was a problem hiding this comment.
These notes are really helpful for determining what your code is doing and your intent
| <img src="http://via.placeholder.com/100x100" /> | ||
| <ul class=reasons-content> | ||
| <li id=reason-1> | ||
| <img src="http://via.placeholder.com/100x100" /> |
There was a problem hiding this comment.
You could save yourself some work by doing this fewer sub-elements. It is possible to get this layout with just a container and one child class ...
|
|
||
| .quote p::before{ | ||
| content: "-- "; | ||
| } |
There was a problem hiding this comment.
An elegant and effective solution to a problem I wasn't able to solve. Nice.
|
|
||
| .team-container h2{ | ||
| text-align: center; | ||
| font-size: 18px; |
There was a problem hiding this comment.
Devin has advised against using pixels for anything except tiny (like 1px) borders -- she says otherwise use em or percentages. I don't feel like I have enough knowledge to have a strong opinion about this but it's worth considering.
| text-align: center; | ||
| display: block | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice implementation of a very tricky layout problem!
| height: 4em; | ||
| width: 8.8em; | ||
| } | ||
|
|
There was a problem hiding this comment.
Given these images, this is exactly how I would want them to resize.
| #about{ | ||
| grid-column: 3/4; | ||
| } | ||
|
|
There was a problem hiding this comment.
Your site is goals for me! Really nice work. I looked at a lot of classmates' sites yesterday and yours is by far the most polished and professional looking. If you are interested in front end development I bet you would be a natural.
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions