Open
Conversation
gyjin
reviewed
Sep 20, 2019
gyjin
left a comment
There was a problem hiding this comment.
Overall, I think you did a great job! Visually your website looks similar to the requirements! A few things:
- You were very thorough with your classes and IDs but I do think some of it can be combined to dry up your code. I put some comments in, such as for the 2 quote sections and unlisted elements.
- You named your classes and IDs well! It was easy to figure out what each class did without even looking at the CSS file.
- Can you show me how to do the navigation bar float thing?! I can't seem to find it in the code.
Again, good job! Your website looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions