Skip to content

Branches - Caroline#31

Open
stupendousC wants to merge 2 commits intoAda-C12:masterfrom
stupendousC:master
Open

Branches - Caroline#31
stupendousC wants to merge 2 commits intoAda-C12:masterfrom
stupendousC:master

Conversation

@stupendousC
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox For the bears, b/c I want the bears to be able to rearrange themselves if you change the window size
Describe a time you chose to use CSS Grid for the nav bar. I wanted to be able to push some items to the left side, and others to the right side. I did that via specifying grid-column-start
What was a challenge you overcame in this project? Having to play with margins vs paddings, and how adjustments to either can affect the overall presentation
What concept did you get the most clarity on through Startrly? Flexbox 1D vs grid 2D, and which one fits what I need.

Copy link

@gyjin gyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think you did a great job! Visually your website looks similar to the requirements! A few things:

  1. You were very thorough with your classes and IDs but I do think some of it can be combined to dry up your code. I put some comments in, such as for the 2 quote sections and unlisted elements.
  2. You named your classes and IDs well! It was easy to figure out what each class did without even looking at the CSS file.
  3. Can you show me how to do the navigation bar float thing?! I can't seem to find it in the code.
    Again, good job! Your website looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants