Conversation
| filter: grayscale(100%) | ||
| } | ||
|
|
||
| section:nth-of-type(6) ul { |
There was a problem hiding this comment.
The first thing I noticed about your website was how perfect the Sponsors section was! So that was the first code I wanted to investigate.
It looks like you figured it out using much less code than I did and it's super readable and makes more sense (however - I don't really understand what flex does - please teach me if we have time after!)
My only suggestion is to name the sections with classes or IDs so that it's easier to find which part of the CSS is taking care of which part of the HTML - I thought I could scan your CSS to find where the Sponsor section was to learn your magic, but found it was easier to open the dev tools and click the section to see what CSS was applied, and realized you select each section by its order.
| @@ -133,7 +134,7 @@ <h2>Sponsors</h2> | |||
|
|
|||
|
|
|||
| <section> | |||
There was a problem hiding this comment.
For each special, unique section, I think it helps a ton to add id="unique-identifier" so that in CSS it can be accessed with #unique-identifier which I think makes it easier to understand what selection each "selection, property, value group" was being operated on.
|
|
||
| <section> | ||
| <div> | ||
| <div class="support_links"> |
There was a problem hiding this comment.
I think classes are supposed to be kebab-case - but I think that might just be personal preference
| font-style: italic; | ||
| } | ||
|
|
||
| .author::before { |
There was a problem hiding this comment.
I like how you added the class .author here -- I think i said something like ... last child of quote section, which isn't as clear and wouldn't have been easy to find to change if any changes were wanted. Good job!
| align-content: center; | ||
| text-align: center; | ||
| } | ||
|
|
There was a problem hiding this comment.
your bear section is beautiful, I don't know why the second row isn't close together... I struggled with that too. Wish I could help!!! :(
| border-radius: 80px; | ||
| filter: grayscale(100%) | ||
| } | ||
|
|
There was a problem hiding this comment.
Great job on the bear border... I don't know why I didn't do this. For some reason I did something really complicated. :( Great job!!! :D
| font-size: 2em; | ||
| margin: 0.67em 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Your website overall has a very bubbly feel, I think I figured out why! Because you made a lot of fonts larger than normal, and I really like it!!
geli-gel
left a comment
geli-gel
left a comment
There was a problem hiding this comment.
I added a couple more comments, I hope you can see them!!
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions