Skip to content

added style and classes at html#26

Open
iamsammysam wants to merge 1 commit intoAda-C12:masterfrom
iamsammysam:master
Open

added style and classes at html#26
iamsammysam wants to merge 1 commit intoAda-C12:masterfrom
iamsammysam:master

Conversation

@iamsammysam
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe a time you chose to use flexbox I used flexbox at the section "why" and "sponsors".
Describe a time you chose to use CSS Grid I used Grid for the "header and footer" and also for the section "meet the team".
What was a challenge you overcame in this project? It was very hard to use grid and flex as tools to position items, they are limited and not intuitive. Another challenge was to style it in a way that doesn't look dated, which I think I quite not achieved.
What concept did you get the most clarity on through Startrly? It made me more familiar with HTML and CSS styles and different commands and ways to use flex and grid. Flexbox is good to change simple orientation and grid is better for more complex resizing and distribution of items.

padding: 5px;
}

.section3 ul li p {
Copy link

@ashassan ashassan Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you created ids for the li's but didn't use it and I was thinking you could use that here if you wanted to by doing .section3 #confortable p or you don't need it at all.

border-style: double;
}

.section4 {
Copy link

@ashassan ashassan Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that you numbered the sections cause it made it easy to find but you can also name it by the headers name

padding: 10px;
}

.section5 {
Copy link

@ashassan ashassan Sep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked how the bears turned out! it looks really good. You can also try to use a grid to get it into the cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants