Branches - Diana #47
Open
Branches - Diana #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, I'm glad you got it in. some small issues here, but overall not bad.
| require 'pry' | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def factorial(n) |
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| # I think this is reversing the string in place? | ||
| def reverse(s) |
| def reverse_inplace(s) | ||
| raise NotImplementedError, "Method not implemented" | ||
| return s if s.length <= 1 | ||
| return reverse_inplace(s[1..-1]) + s[0] |
There was a problem hiding this comment.
This creates a new array, so it's not in place
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n) |
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # NOT PASSING TESTS | ||
| def nested(s) |
| raise NotImplementedError, "Method not implemented" | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def search(array, value, i = 0) |
| return false | ||
| end | ||
|
|
||
| while l < s.length |
There was a problem hiding this comment.
You don't need a while if it's recursive.
You can make the base case
return true if i >= r
| tracker += 0 | ||
| end | ||
|
|
||
| return tracker if i < -(n.length) |
| def digit_match(n, m) | ||
| raise NotImplementedError, "Method not implemented" | ||
| # NOT PASSING TESTS | ||
| def digit_match(n, m, i = -1) |
There was a problem hiding this comment.
You can also pull off digits by % 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, it's late! Passing MOST of the tests except for nested & digit match