Open
Conversation
added 2 commits
September 6, 2019 21:26
CheezItMan
reviewed
Sep 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, I like how you did the bonus BFS method. Do note that recursion does impact space complexity. Otherwise this is outstanding!
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(logn) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Since you're using a recursive add_node helper method, you are using the system stack and this impacts space complexity. Since you are making O(log n) recursive calls on a balanced tree this would have a space complexity of O(log n).
| return 0 unless node | ||
| left_counter = height_counter(node.left) | ||
| right_counter = height_counter(node.right) | ||
| counter = left_counter > right_counter ? left_counter : right_counter |
| i += 1 | ||
| current = array[i] | ||
| end | ||
| return array.map do |node| |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(2n) |
There was a problem hiding this comment.
In Big-O we drop the coefficient so this should be Space complexity of O(n)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.