Skip to content

Ports-Elle #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dev-elle-up wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports-Elle #40

dev-elle-up wants to merge 1 commit into from

Conversation

@dev-elle-up
Copy link

@dev-elle-up dev-elle-up commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar
Give one example where you choose Flexbox over Grid
Where did you choose to use CSS Grid and why did you make that decision
What was the hardest part of this assignment, and why was it difficult
What concept did you get the most clarity on through Startrly?

sjscotton
sjscotton reviewed Apr 5, 2019
View reviewed changes
main.css
display: grid;
grid-template: repeat(7, 1fr) / 150px, 350px, 150px;

}
Copy link

@sjscotton sjscotton Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love the idea to put the whole thing into a grid. Im excited to see how that ends up helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sjscotton sjscotton sjscotton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dev-elle-up @sjscotton