Ports - Kim #2
Ports - Kim #2
Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work, you hit all the learning goals here. Take a look at my comments regarding time complexity and let me know if you have questions.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) - where n is equal to the length of the input string |
There was a problem hiding this comment.
Because s[0..-2] will also create a new array, this makes the time complexity also O(n^2)
| raise NotImplementedError, "Method not implemented" | ||
| # Time complexity: O(n) - where n is the length of the string / 2 | ||
| # Space complexity: O(n) - where n is the length of the string / 2 | ||
| def reverse_inplace(s, i = 0, j = s.length - 1) |
| raise NotImplementedError, "Method not implemented" | ||
| if s == "" | ||
| return true | ||
| elsif s.length == 1 || s[0] != "(" || s[-1] != ")" |
There was a problem hiding this comment.
if s.length ==1 then it can't have a matching paren.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) - where n equal the length of the string / 2 |
There was a problem hiding this comment.
Because s[1..-2] creates a new string of length n-2, this is an O(n^2) for both space and time.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) - where n equals the length of the array |
| # Space complexity: ? | ||
| # Time complexity: O(n) - where n equals the length of the string / 2 | ||
| # Space complexity: O(n) - where n equals the length of the string / 2 + length of the string | ||
| def is_palindrome(s) |
There was a problem hiding this comment.
O(n^2) similar to the above, look at your reverse in place, could you use a similar technique?
| def digit_match(n, m) | ||
| raise NotImplementedError, "Method not implemented" | ||
| end No newline at end of file | ||
| if (n / 10 == 0) || (m / 10 == 0) |
There was a problem hiding this comment.
These ifs could be simplified a bit. Otherwise very good!
2 participants
No description provided.