Ports - Elle #12
Open
Ports - Elle #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 29, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Gave you some feedback. Take a look at my notes for reverse_in_place. Not bad with what you've written. Let me know if you have questions.
|
|
||
| # e.g. reverse("hello world") will return "dlrow olleh" | ||
|
|
||
| # Time complexity: O(n) (I think? I'm not sure on this.) |
There was a problem hiding this comment.
Because s[0..-2] creates a new string and you have n recursive calls this will be O(n^2) for both time and space.
| return s if (s.length <= 1) | ||
| return s[-1] + reverse(s[0..-2]) | ||
|
|
||
| # CHRIS: Here is the mess of commented out code I warned you about. I ended up figuring it out when doing the Exercism problem this weekend and was able to quickly convert that code to Ruby! :D :D :D Hooray!! |
There was a problem hiding this comment.
Think about this,
You can make a helper method reverse_helper which takes the string and left_index and right_index. The base case is when left_index >= right_index. Otherwise you can swap the characters at left_index and right_index, then call the helper recursively adding one to left_index and subtracting one from right_index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented def factorial(n) and def revers(s).
Chris, I ended up figuring it out after solving the same problem in Exercism! 👍