Open
Conversation
CheezItMan
reviewed
Oct 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Hey Laneia,
Nice work, thanks for the PR. In the future with later submissions, can you ping me so I notice. Overall very well done. Take a look at my comments and let me know if you have questions.
| # insert the new node at the beginning of the linked list | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
| # returns true if found, false otherwise | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
| # returns the data value and not the node | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_max |
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
I think you meant space complexity O(1)
| # returns the data value and not the node | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def find_min |
| # assume indexing starts at 0 while counting to n | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(n) |
| # returns true if a cycle is found, false otherwise. | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def has_cycle |
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(value) |
| # returns nil if the linked list is empty | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last |
| # list is sorted in ascending order | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def insert_ascending(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.