Open
Conversation
CheezItMan
reviewed
Sep 3, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You did pretty well on the methods you wrote, but didn't get a lot of it done. Let me know if you have questions or need to meet and look at things.
Hopefully the next one will go better.
| end | ||
| # method that returns the length of the singly linked list | ||
| # Time Complexity: O(n) where n equals the length of the linked lisst | ||
| # Space Complexity: O(n) where n equals the length of the linked list |
There was a problem hiding this comment.
Space complexity O(n)? You aren't creating any additional data structure or using recursion.
| def reverse | ||
| raise NotImplementedError | ||
| end | ||
| # method that returns the value at a given index in the linked list |
There was a problem hiding this comment.
And a bunch of unimplemented methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.